WIP: Fix issues on Windows and add CI testing

sous-chefs / users

Development repository for the users cookbook

https://supermarket.chef.io/cookbooks/users

Apache License 2.0

138 stars 218 forks source link

WIP: Fix issues on Windows and add CI testing #448

Open ramereth opened 3 years ago

frank-m commented 3 years ago

Afaik Windows was not a supported platform before, at least it was not in the supports or in the readme.

So super interesting that it worked before, but I suppose we will have to exclude some of the tests for Windows as test with a uid will never pass I think. Maybe we can try replacing that with a SID, although I am not sure if you are allowed to chose your own SID. I thought Windows always generated that.

Stromweld commented 1 year ago

In the latest release from PR #467 I updated the CI pipeline and added windows but it failed due to some more linux specific settings in code. Looks to be more work that will need to go into supporting windows then just adding it to CI workflow.