sous-chefs / users

Development repository for the users cookbook
https://supermarket.chef.io/cookbooks/users
Apache License 2.0
138 stars 217 forks source link

Simplify home directory type detection #49

Closed iroller closed 10 years ago

iroller commented 10 years ago

Also this fixes the bug when it was trying to detect FS type at resource compilation stage. Now it assumes remote home dir should be mounted beforehand.

sethvargo commented 10 years ago

@iroller I'm impressed. Did you plan to have the 66 additions and 66 deletions :smile:. This looks good to me. However, it looks like Travis isn't running (perhaps leftover from the transfer). Assuming these tests pass for you locally, go ahead and merge. I'll figure out the Travis bits later.

iroller commented 10 years ago

@sethvargo hehe, I just noticed it

Doesn't look like Travis was ever configured in this cookbook

sethvargo commented 10 years ago

@iroller https://github.com/sethvargo-cookbooks/users/pull/50

sethvargo commented 10 years ago

It's still sitting in the queue: https://travis-ci.org/sethvargo-cookbooks/users/builds/21025461

iroller commented 10 years ago

Should be ok once you added rake in Gemfile