search

sous-chefs / vagrant

Development repository for the vagrant cookbook
https://supermarket.chef.io/cookbooks/vagrant
Apache License 2.0
57 stars 52 forks source link

Convert the resources to custom resources #103

Closed MarkGibbons closed 5 years ago

MarkGibbons commented 5 years ago

Add a env property to the plugin resource to allow for setting environment variables. Add and example of installing the vagrant-libvirt plugin, this plugin requires specific environment variable settings. See https://github.com/vagrant-libvirt/vagrant-libvirt/issues/891

Description

Update the cookbook to use custom resources. Add an env property to the plugin resource. Add examples in the tests for using the env property. Remove the chef 13 tests and instances. Use chef 14 as the base install.

Issues Resolved

101

Check List

MarkGibbons commented 5 years ago

This PR addresses issue #101.

kitchen-porter commented 5 years ago
1 Warning
:warning: This is a big Pull Request.

Generated by :no_entry_sign: Danger

MarkGibbons commented 5 years ago

@qubitrenegade Thanks for looking at it. Rewriting to use custom resources sometimes makes for a big pull request.

damacus commented 5 years ago

@MarkGibbons looks great. What do we need to get this finished off? Looks pretty close

MarkGibbons commented 5 years ago

Rebase and push. Probably early next week..

MarkGibbons commented 5 years ago

Rebased and fixed the suggestions. Waiting for a review.

MarkGibbons commented 5 years ago

Resolves #101. One of the tests shows the exact syntax needed.

lock[bot] commented 5 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.