Automated PR: Cookstyle Changes - Githubissues

sous-chefs / varnish

Development repository for the varnish cookbook

https://supermarket.chef.io/cookbooks/varnish

Apache License 2.0

56 stars 117 forks source link

Automated PR: Cookstyle Changes #218

Closed xorimabot closed 3 years ago

xorimabot commented 3 years ago

Hey! I ran Cookstyle 7.12.2 against this repo and here are the results. This repo was selected due to the topics of chef-cookbook

Changes

Issues found and resolved with resources/varnish_repo_debian.rb

1:1 refactor: Chef/Deprecations/ResourceWithoutUnifiedTrue - Set unified_mode true in Chef Infra Client 15.3+ custom resources to ensure they work correctly in Chef Infra Client 18 (April 2022) when Unified Mode becomes the default. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_resourcewithoutunifiedtrue)

Issues found and resolved with resources/varnish_repo_redhat.rb

1:1 refactor: Chef/Deprecations/ResourceWithoutUnifiedTrue - Set unified_mode true in Chef Infra Client 15.3+ custom resources to ensure they work correctly in Chef Infra Client 18 (April 2022) when Unified Mode becomes the default. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_resourcewithoutunifiedtrue)

Issues found and resolved with resources/vcl_file.rb

1:1 refactor: Chef/Deprecations/ResourceWithoutUnifiedTrue - Set unified_mode true in Chef Infra Client 15.3+ custom resources to ensure they work correctly in Chef Infra Client 18 (April 2022) when Unified Mode becomes the default. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_resourcewithoutunifiedtrue)

Issues found and resolved with resources/vcl_template.rb

1:1 refactor: Chef/Deprecations/ResourceWithoutUnifiedTrue - Set unified_mode true in Chef Infra Client 15.3+ custom resources to ensure they work correctly in Chef Infra Client 18 (April 2022) when Unified Mode becomes the default. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_resourcewithoutunifiedtrue)

kitchen-porter commented 3 years ago

	2 Warnings
:warning:	This is a big Pull Request.
:warning:	This is a Table Flip.

Generated by :no_entry_sign: Danger

damacus commented 3 years ago

This needs a metadata update

ramereth commented 3 years ago

@Xorima why did you close this? I was working on getting it merged

xorima commented 3 years ago

Some automation I ran, reopen it mate :)

kitchen-porter commented 3 years ago

Released as: 5.0.0