sousou03 / glmatrix

Automatically exported from code.google.com/p/glmatrix
0 stars 0 forks source link

api name change suggestion #26

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
Perhaps it would be clearer if mat4.multiply was renamed mat4.preMultiply. Then 
have mat4.multiply(A,B) do A*B (instead of B*A), and for completeness set 
mat4.postMultiply = mat4.postMultiply.

Original issue reported on code.google.com by Drew.Whitehouse on 26 Jun 2010 at 7:16

GoogleCodeExporter commented 8 years ago

Original comment by Tojiro@gmail.com on 1 Jul 2010 at 9:37

GoogleCodeExporter commented 8 years ago
Oops, "mat4.postMultiply = mat4.postMultiply" should read "mat4.postMultiply = 
mat4.multiply".

Original comment by Drew.Whitehouse on 1 Jul 2010 at 9:59

GoogleCodeExporter commented 8 years ago
is there a need to do this a it is fairly easy to switch the arguments in 
multiply??

Original comment by jeroom832@gmail.com on 3 Aug 2010 at 4:39

GoogleCodeExporter commented 8 years ago
I feel that for the current iteration of the library a single multiply is 
enough (as was pointed out it's pretty easy to just flip the args). I will 
consider, however, a more complete set of functions like this for a potential 
version 2.

Original comment by Tojiro@gmail.com on 10 Oct 2010 at 4:02

GoogleCodeExporter commented 8 years ago
@Drew.Whitehouse I like your suggestion. Come over to 
https://github.com/feisty/math and lodge an issue ^w^

Original comment by pyrotech...@gmail.com on 15 Dec 2010 at 12:26

GoogleCodeExporter commented 8 years ago
I feel that for the current iteration of the library a single multiply is 
enough (as was pointed out it's pretty easy to just flip the args). --> it's an 
issue of API convention and an easy way of introducing bugs for the people 
using the library for the first time.

Also, when you do not specify the dest parameter, the data flow ... is a bit 
unnerving ;).

arg1 = arg2 * arg1

Original comment by Pana...@gmail.com on 12 Apr 2011 at 10:11