search

southalc / podman

Puppet module for podman
Apache License 2.0
13 stars 30 forks source link

Add management of podman-autoupdate timer #44

Closed jcpunk closed 1 year ago

jcpunk commented 2 years ago

This adds a flag to switch on or off the podman-autoupdate service timers.

southalc commented 2 years ago

This change gives me pause. The defined type "podman::container" currently uses the "update" parameter to control this behavior. When the "update" parameter value is false, the intent is to re-deploy the container only when the version is re-assigned by the puppet catalog. When "update" is true, the digest of the current container image is checked against that of the registry and re-deployed when a difference is detected. It may be worth switching the custom update behavior of the defined type to just use podman-autoupdate, but I'll need to spend a little more time with it. If you'd like to investigate that I'd be happy to get your thoughts.

jcpunk commented 2 years ago

I'll confess I've not totally thought through how these interact. Mostly I saw a flag that might be useful and figured I'd contribute it back up....

southalc commented 1 year ago

Dropping this in favor of the currently implemented update method used by the module.