southalc / podman

Puppet module for podman
Apache License 2.0
13 stars 30 forks source link

Set service title to a more unique value. #45

Closed jcpunk closed 2 years ago

jcpunk commented 2 years ago

When using https://forge.puppet.com/modules/puppet/systemd the catalog becomes parse order dependant. This change should resolve this issue. It does end up checking the service more than once, but is very non-invasive.

southalc commented 2 years ago

I wonder if we could we just remove the "enable => true" part of the "systemd-logind" service? I noticed that this isn't really doing anything anyway since the state of this service is "static" in systemd. If the ensure_resource service declaration matches that from puppet-systemd there should be no conflict using the modules together. This also avoids managing the service more than once. Could you verify this works (or not)?

jcpunk commented 2 years ago

On my site, the podman module gets parsed before the systemd module. So the resources are already created via ensure_resource inside podman before the systemd module tries to create them and conflicts.

jcpunk commented 2 years ago

Any chance for a 0.6.1 release with this patch?

southalc commented 2 years ago

Posted it.