Proposal of moving subclasses into main class (based on PR #69 & PR #70)

southalc / podman

Puppet module for podman

Apache License 2.0

13 stars 30 forks source link

Proposal of moving subclasses into main class (based on PR #69 & PR #70) #72

Closed Phil-Friderici closed 11 months ago

Phil-Friderici commented 12 months ago

From my perspective podman::install, podman::options, and podman::service should be integrated into the main class. The code in question is less than a page and I think it is easier to read and understand with less classes.

Unit testing much easier without the subclasses. No more pre_condition and other 'hacks' to get them running :)

Hope you like and agree.

For PDK validate / testing results see my fork

Phil-Friderici commented 11 months ago

closed in favour of #75