Implementation not generalisable

southworks / CapsNet-CNTK

A CNTK implementation of CapsNet based on Geoffrey Hinton's paper Dynamic Routing Between Capsules

6 stars 5 forks source link

Implementation not generalisable #1

Open akanimax opened 6 years ago

akanimax commented 6 years ago

The module here https://github.com/southworkscom/CapsNet-CNTK/blob/master/CapsLayer.py has the function DigitCaps(input, num_capsules, dim_out_vector, routings=3, name='DigitCaps') Out of which, the num_capsules and dim_out_vector are not used in the function anywhere. Whatever values we set for these two, the function returns the hardcoded (as described in the paper) network. It would be very convenient if this interface were generalisable.

rnrneverdies commented 6 years ago

Hi @akanimax, thanks for the contribution. Agree, this was an oversight. Feel free to send a PR.

akanimax commented 6 years ago

Sure. I'll work on it. :+1: