southworks / botbuilder-js

JavaScript SDK used to build chat bots for the Microsoft Bot Framework.
MIT License
1 stars 3 forks source link

port: [#6841] SkillDialog.InterceptOAuthCardsAsync doesn't support CloudAdapter #482

Closed ceciliaavila closed 1 month ago

ceciliaavila commented 1 month ago

Fixes # 4741

minor

Description

This PR ports the changes in [#6848](https: //github.com/microsoft/botbuilder-dotnet/pull/ 6848) updating the interceptOAuthCards method in SkillDialog to support CloudAdapter in combination with expect replies delivery mode.

Specific Changes

Testing

These images show the token exchange for CloudAdapter and expect replies before and after the fix. image

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11240680509

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs/src/skillDialog.ts 11 14 78.57%
<!-- Total: 11 14 78.57% -->
Totals Coverage Status
Change from base Build 11237779416: -0.01%
Covered Lines: 20444
Relevant Lines: 22944

💛 - Coveralls
ceciliaavila commented 1 month ago

/promoted 4766