search

souvik1997 / obdython

An OBD-II compliant car diagnostic tool library
GNU General Public License v2.0
20 stars 11 forks source link

pep8 pass #1

Closed bignaux closed 9 years ago

souvik1997 commented 9 years ago

Thanks for the pull request. Did you manually edit the file to comply with pep8 or did you use a program?

I'm asking because the diff is huge.

souvik1997 commented 9 years ago

Additionally, your file doesn't follow E501 (line too long error).

bignaux commented 9 years ago

i manually did it after pydev formatting (tab spacing). I'm ignoring E501 since i'm not totally agree with 80 char limitation ... It's huge because you were using tab spacing. There is still some work, like 'type' variable, a reserved keyword, useless import. But i prefer see step by step how contributions are received before spend too much time. This patch contains no change code.

souvik1997 commented 9 years ago

Thanks for the contribution!