souzaonofre / android-xbmcremote

Automatically exported from code.google.com/p/android-xbmcremote
0 stars 0 forks source link

Sanity check for settings #167

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Change the eventserver port from 9777 to 9777x in the app.
2. Go to the remote control and press any button.

What is the expected output? What do you see instead?
Force Close

What version of XBMC Remote are you using?
App 0.6.3

Which Android device are you using (and which ROM, if custom)?
HTC Magic with HTC sense rom 3.05.401.3

Which XBMC revision are you running running and on on which platform?
PRE-10.5 r27694

Please provide any additional information below.
If I change to any other port that doesn't start with 9777 it doesn't crash.

Original issue reported on code.google.com by jenny1.l...@gmail.com on 14 Feb 2010 at 7:41

GoogleCodeExporter commented 9 years ago
Ports can only be between 1 and 65535. Maybe the app can check the port to 
check if the 
entered port is in that range.

Original comment by codename...@gmail.com on 14 Feb 2010 at 7:52

GoogleCodeExporter commented 9 years ago
Yeah, I'll rename the bug.
A sanity check would be good. Same thing as for eventserver port should apply 
to the
port. Or sanity check of hostname etc...

Original comment by till.ess...@googlemail.com on 15 Feb 2010 at 12:22

GoogleCodeExporter commented 9 years ago

Original comment by till.ess...@googlemail.com on 15 Feb 2010 at 9:12

GoogleCodeExporter commented 9 years ago

Original comment by till.ess...@googlemail.com on 15 Feb 2010 at 9:12

GoogleCodeExporter commented 9 years ago

Original comment by till.ess...@googlemail.com on 18 Feb 2010 at 3:06

GoogleCodeExporter commented 9 years ago
Duh. Can't we assume the user has a minimal technical competence? I agree 
eventserver 
settings should be read from httpapi if possible however.

Original comment by phree...@gmail.com on 21 Apr 2010 at 8:33

GoogleCodeExporter commented 9 years ago
@phreezie: Well first at all, it was a mistake to not see that the number was 
over
65k, so technical competence wasn't the problem here.

For the second, a user with "minimal technical competence" would hardly know 
that a
port cant be higher then 65535.

For the third, a "minimal technical competence" hasn't been consider anywhere 
else,
for example that the user cant have the brain enough to press a button for 1 
sec,
instead of tapping it 0,2sec, like a normal TV remote works. No no, there we 
need a
dialog for the 0,00001% of the users that doesn't have the "true minimal 
technical
competence".

Original comment by bolin.andreas@gmail.com on 21 Apr 2010 at 9:47

GoogleCodeExporter commented 9 years ago
Issue 377 has been merged into this issue.

Original comment by till.ess...@googlemail.com on 1 Sep 2010 at 7:09