sovanna / angular-material-sidenav

Simple component that reproduce the Angular Material Style SideNav Menu from their own website
http://sovanna.github.io/angular-material-sidenav/
109 stars 55 forks source link

Toggle not working with Angular v1.5.0 and Angular Material v1.0.6 #26

Open Spatlani opened 8 years ago

Spatlani commented 8 years ago

image

I am using the demo code. When I try to open the toggle menu, the arrow icon changes but the dropdown doesn't work.

Need Help! Thanks.

LockonF commented 8 years ago

As of the latest version, line 309 of angular-material-sidenav.js has the following condition

if (!$mdSidenav('left').isOpen() && open) {
                            return;
}

I've managed to get the desired behaviour by commenting that specific line.

nanoninja commented 8 years ago

Thanks ! I had the same problem through bower... This works by downloading the source via github and recovering the file to the root.

Spatlani commented 8 years ago

Thanks, It works after commenting. Will it be fixed in later builds?

bastianwegge commented 8 years ago

What's the meaning of this anyway? I'd make a pull-request and just remove it, if it's doing trouble anyway.

mateuo commented 8 years ago

Thanks LockonF . It works for me

tiste commented 8 years ago

Any fix on master soon?

Thanks @LockonF, works for me.

sovanna commented 8 years ago

gonna do the fix before the end of the day. Sorry guys for the late response.

tiste commented 8 years ago

Great, thanks @sovanna

tiste commented 8 years ago

Any news? @sovanna

sovanna commented 8 years ago

@tiste I've looked and start from the beginning but didn't arrive to reproduce the bug. did you have the bug ? or maybe I just don't understand the description.

I did : git clone the project cd demo npm install bower install grunt serve and the demo work perfectly

tiste commented 8 years ago

It's not related to your demo but to projects which import a recent version of angular-material.

For instance, I use a 1.0.9 and it fails. Hope that helps.

sovanna commented 8 years ago

strange, I also angular-material 1.0.9, and I have the toggle menu, I click , the dropdown works.. don't understand the problem

EkoAdiWijayanto commented 8 years ago

@sovanna, i think this will solve the issue

if (!$mdSidenav('left').isLockedOpen() && !$mdSidenav('left').isOpen() && open) { return; }