search

soveran / cuba

Rum based microframework for web development.
http://cuba.is
MIT License
1.44k stars 248 forks source link

Use a less strict test for deleting cookies #41

Closed jeremyevans closed 10 years ago

jeremyevans commented 10 years ago

My environment uses the following in this test:

"foo=; expires=Thu, 01-Jan-1970 00:00:00 GMT"

I'm guessing the test should still be considered passing in this case, but if there is a reason to consider this a failure, it should probably be fixed in the code.

soveran commented 10 years ago

We discussed this briefly over IRC, and @jeremyevans was running the tests with Rack 1.4.5. As the idea is to test a basic mechanism in Rack, I think we can keep the test tied to the Rack version specified in .gems, which is currently 1.5.2.

frodsan commented 10 years ago

I think this is a dup of https://github.com/soveran/cuba/pull/44. Now that the contributing section specifies that you should install the dependencies from .gems, I would close this.

soveran commented 10 years ago

Closing this for now. If we continue discussing and change our minds, we can reopen it.