search

soveran / cuba

Rum based microframework for web development.
http://cuba.is
MIT License
1.44k stars 249 forks source link

Expose the 404 handler #68

Closed topalovic closed 8 years ago

topalovic commented 9 years ago

Exposes the hard-coded 404 handler so it can be overridden in subclasses or plugins.

I believe it's reasonable to expect the default catch-all to be customizable without resorting to monkey patching or redefining core methods.

frodsan commented 8 years ago

:+1:

soveran commented 8 years ago

@topalovic Do you envision any downsides to this approach? I don't, and I think this can be a good change. Let me know what your thoughts are.

topalovic commented 8 years ago

I can't see any downsides either and it passed the tests at the time I opened the pull. So if it's still green, I believe it's good to go.

soveran commented 8 years ago

@topalovic Thanks a lot for this change :-)

frodsan commented 8 years ago

@soveran do you consider implementing this feature in Syro?

soveran commented 8 years ago

@frodsan Yes, but I have in mind two very different approaches.

soveran commented 8 years ago

@frodsan ping me on IRC and I'll tell you.