search

sovity / authority-portal

Allows a Dataspace Authority to manage its participants.
https://sovity.de/en/build-entire-data-space-en/
Apache License 2.0
5 stars 0 forks source link

fix app title logic #371

Closed illfixit closed 1 day ago

illfixit commented 2 weeks ago

What issues does this PR close? closes #237 Website title does not update in some scenarios

Unauthenticated image

Onboarding (both organization and user) image

Pending image

Rejected image

404 Page not found (page + title) image

Logged In image

### Checklist
- [x] The PR title is short and expressive.
- [ ] I have updated the CHANGELOG.md. See [changelog_update.md](https://github.com/sovity/authority-portal/tree/main/docs/dev/changelog_updates.md) for more information.
- [ ] I have updated the Deployment Migration Notes Section in the CHANGELOG.md for any configuration / external API changes.
- [x] I have performed a **self-review**
illfixit commented 1 week ago

Implementation-wise, that looks good.

I'm not sure though if this is okay from a business perspective, namely "MDS Portal" being removed from the title. This PR does more than is laid out in the connected issue.

Someone should clarify if this is okay.

@jkbquabeck @AbdullahMuk

MDS part is just a tiny bug after extracting it into separate PR, we can fix it very quick. I agree that it's a little more than in bug and the issue itself came internally iirc (from JK), not from MDS.

illfixit commented 1 week ago

@kamilczaja MDS is back in Titles