sovity / edc-ce

sovity Community Edition EDC

https://sovity.de/en/connect-to-data-space-en/

Apache License 2.0

54 stars 16 forks source link

Performing a Data-Transfer for Data-Offers retrieved through the Catalog URL in the Catalog Browser wont work #75

Closed efiege closed 1 year ago

efiege commented 1 year ago

Bug Report

Description

Performing a data-transfer should not be possible for data-offers, which where retrieved using the Catalog URL in the Catalog Browser.

https://github.com/sovity/edc-ui/blob/845482ed21a94b2ebe2448786efaac75db58a801/src/modules/edc-demo/components/contract-viewer/contract-viewer.component.ts#L130

Expected Behavior

Retrieving the contractnegotiation using the contractId
Using the contractnegotiations counterPartyAddress to find the other connectors address

Observed Behavior

The catalog is fetched
Then the asset is used to retrieve the counterParty from the assets originator field

richardtreier commented 1 year ago

Temporary workarounds can suffice due to the next milestone being probably 3 months away from now or so.

To be fair, the API needs to give us a useful ID in contract agreements so that we can initiate transfers.

The other way would be that the transfer API could accept a contract agreement ID. I mean what else would you use these APIs for otherwise, if the transfer process itself doesn't work.

Ideally this would be done in the main EDC Connector repository, right?

SebastianOpriel commented 1 year ago

Latest adjustments on main branch will fix the issue, but needs a workaround-extension in edc.

[ ] @efiege please add workaround-extension to edc-extensions repository and adjust deployments + docker-composes accordingly
[ ] @richardtreier please create a new release with the fixes

richardtreier commented 1 year ago

Release was skipped due to the temporary nature of our changes and it being incompatible to open source backends (until we moved the workaround-extention to edc-extensions), so the release is done with using the container SHA-commits