sovity / edc-ce

sovity Community Edition EDC
https://sovity.de/en/connect-to-data-space-en/
Apache License 2.0
55 stars 14 forks source link

Transfer History is updated when asset is modified #978

Open drmVR opened 3 months ago

drmVR commented 3 months ago

Description - What happened? *

When editing an asset, the Transfer History in the Connector UI is also updated, eventhough the asset description was a different one when the contract was negotiated.

Expected Behavior *

The Transfer History should persist the asset at the time of the contract negotiation.

Observed Behavior *

The Transfer History is updated and displays the modified version of the asset.

Steps to Reproduce

Context Information

No response

Relevant log output

No response

Screenshots

No response

tmberthold commented 3 months ago

Hi @drmVR, Thank you for opening this issue! 🚀 We appreciate your feedback and will review it as soon as possible. Your issue has been forwarded to our internal team for further investigation (@jkbquabeck).

ip312 commented 3 months ago

The situation is even more complex. Not only Transfer History, but also Contract History is updated as soon as the asset was edited. For the Contract History the requirement is pretty clear: the asset description at the time of the contract negotiation should be persisted. For the Transfer History different solutions are applicable. The best one: the asset description at the time of transaction is persisted. The second best one: the asset description at the time of contract negotiation is persisted. The third best one: the current solution.

ip312 commented 3 months ago

Therefore the logging of asset changes is absolutely crucial, not nesessarily "the complete change history and versions" as stated in the linked issue, but at least a timestamp of the change.