sovity / edc-ui

Connector UI for the sovity EDC Community Edition.
https://sovity.de/en/connect-to-data-space-en/
Apache License 2.0
32 stars 12 forks source link

fix auth proxy issues by disabling caching for non-static files #584

Closed richardtreier closed 7 months ago

richardtreier commented 8 months ago

Feature Request

Description

As a user, I want the system to properly handle page caching during logout, So that I do not encounter a broken page due to the browser skipping the request.

How does this tie into our current product?

This error occurs because the browsers cached the page, skipping the request, which would otherwise redirect to a keycloak browser flow.

We have an auth proxy for this otherwise unprotected UI image.

This request focuses on improving the user experience during logout and ensuring the security of the UI image.

Acceptance Criteria

Solution Proposal and Work Breakdown

The solution is to add the same thing we added for the authority portal in the EDC CE.

- [x] Update the nginx conf

@AbdullahMuk @kulgg

kulgg commented 7 months ago

I discovered another bug while working on this issue: https://github.com/sovity/edc-ui/issues/591 The /logout page does not work during local development (unrelated to nginx)

kulgg commented 7 months ago

This issue might be a misdiagnosis. In the staging the environment the blank page is caused by the same NullInjectionError. Here, the o probably refers to PreviousRouteListener (JS minimization in prod).

core.mjs:9171 ERROR Error: Uncaught (in promise): NullInjectorError: R3InjectorError(o)[o -> o -> o -> o -> o]: 
  NullInjectorError: No provider for o!