Fix UI incorrectly displays errors in Policy

[tmberthold]

Enhancement

Description

If policies are created via the Management-API that cannot be created via the UI, the UI indicates that the policy is incorrect, even though they technically work.

Expected Behavior

Don't show errors in the UI if technically there aren't any. Or expand the UI so that all functionalities of the Management-API are supported.

Observed Behavior

Steps to Reproduce

Steps to reproduce the behavior:

Create a policy via Management-API, which cannot be created via the UI but still works technically.

Context Information

• Here in the specific cases EDC EE based on EDC 0.2.1 were used.
• How it works with the Management-API. The Management-API enables customers to create any policy so they just give it a try because they know the policy from other use-cases. The management API has no input-validation and allows any POST bodies, meaning they can just try it out changing the Body, there are no specifications enforced like there are with the UI.
• That's where the UI fails, because user can create any Policy with the Management-API, whether it is technically correct or not, which is not the case with the UI. The UI then tries to display all policies in the tab but simply doesn't know the syntax of some of the policies.

Possible Implementation and Work Breakdown

Possible short-term solution: Hide the error message for the scenario described above given that the policy actually works.

[kamilczaja]

While the UI is not supporting every edge-case and all shenanigans that could be achieved by using the management API, we recently implemented and/or constraints and empty constraints officially into the UI and the API Wrapper. This should suffice to support most use cases found in MDS or Catena-X.

So, while we don't have and probably don't intend to implement everything described in this issue, the linked MDS issue was fixed here: https://github.com/sovity/edc-ce/pull/1012

The question here is: Can this be closed?

[illfixit]

the original MDS issue includes only 0 constraints error and as mentioned before it was already fixed. the second part in our issue (not in MDS) also mentions other errors like OrConstraints are currently unsupported

[AbdullahMuk]

@kamilczaja @illfixit thanks for sharing these insights.

We will assess the efficiency of the current fixes after all connectors have been upgraded to latest version of edc-ui. moving this issue to a later sprint.

[richardtreier]

• Our API Wrapper might accidentally display an error for empty policies.
  • I believe this was once the case, but is now fixed
  • [x] Should be fixed, according to Ilia
• Our API Wrapper should support now OR, XOR, AND without errors.
  • Otherwise it needs to be adjusted (TODO: confirm)
  • [ ] Confirm: Does this still happen?
• Our API Wrapper supports policies that were created with multiple Permissions or multiple Constraints per Permission:
  • It will point out, though, that it is preferred that you use an AND Constraint, and only a single Permission and a single Constraint.
  • This is intended.
  • This does not impede functionality.
  • This is rather a deprecation notice to people still creating policies in the old way.
  • There is no distinction between errors and warnings right now