search

sovity / edc-ui

Connector UI for the sovity EDC Community Edition.
https://sovity.de/en/connect-to-data-space-en/
Apache License 2.0
33 stars 11 forks source link

asset-select.component.html: broken comparison #684

Closed bearn01d closed 4 months ago

bearn01d commented 4 months ago

Expected Behaviour

Observed Behaviour

Steps to Reproduce

The comparison of assets in the asset-select component is broken: https://github.com/sovity/edc-ui/blob/47c63828bce6936b76cbda82eebb34a7f0804c84/src/app/routes/connector-ui/contract-definition-page/asset-select/asset-select.component.html#L7 The problem is that UiAssetMapped has the field assetId but not an id. Therefore, the comparison is undefined with undefined and as such worthless. Changing to assetId would fix this.

Screenshots

tmberthold commented 4 months ago

Hello and thank you for this report!

I will bring this up internally to our PO (@AbdullahMuk) and, depending on the outcome, we will discuss it with the component owners of the edc-ui repo.

tmberthold commented 4 months ago

Hi @bearn01d, I got asked to ask you to please provide additional information in the issue-comment itself to follow our Bug Report Template structure, could you please adapt the issue to follow the structure? I already added the structure elements to the issue itself.