search

sowawa / fluent-plugin-slack

132 stars 52 forks source link

Channel should not be mandatory when using a webhook #19

Closed lvicentesanchez closed 7 years ago

lvicentesanchez commented 9 years ago

An incoming-webhook has to be created for a given channel; forcing users to provide a channel through configuration in that case, makes the plugin unusable if you want to send logs to a private channel.

lvicentesanchez commented 9 years ago

From the documentation:

Channel Override
Incoming webhooks have a default channel. You can override it with the channel parameter in your JSON payload.

A public channel can be specified with "channel": "#other-channel", and a Direct Message with "channel": "@username".

{
    "channel": "#other-channel",    // A public channel override
    "channel": "@username",         // A Direct Message override
}
sonots commented 7 years ago

Fixed via https://github.com/sowawa/fluent-plugin-slack/pull/35 and #39