search

sowawa / fluent-plugin-slack

132 stars 52 forks source link

Add messages to the fallback attribute #29

Closed eisuke closed 8 years ago

eisuke commented 8 years ago

Add messages to the fallback attribute for IRC clients connecting to Slack.

sonots commented 8 years ago

Could you add an option for this? I am comfortable with current behavior.

eisuke commented 8 years ago

Could you add an option for this?

You’ve got a point. fb353db

sonots commented 8 years ago

thx!

sonots commented 8 years ago

@eisuke I should've asked this first. if you do not specify title option, https://github.com/sowawa/fluent-plugin-slack/blob/23f9340a4a6d58d3ad3eedc994b1eedd0c2c9781/lib/fluent/plugin/out_slack.rb#L301-L314 this lines are used, so all messages should be popped up. Was this not enough for you?

eisuke commented 8 years ago

No, without title option is not enough.

My problem is that some people use official slack client, and others connect to Slack via IRC client. The former want to watch richly-formatted messages with title attribute, the later want to get information equal to the former (the later can only get title).

sonots commented 8 years ago

Okay, thanks

sonots commented 8 years ago

0.6.3 is released!

eisuke commented 8 years ago

thanks!