Allow individual control of LEDs

sowbug / weblight

WebUSB LED. Hardware, software, and firmware.

https://sowbug.github.io/weblight/

Other

187 stars 38 forks source link

Allow individual control of LEDs #44

Open sowbug opened 7 years ago

sowbug commented 7 years ago

The hardware has the capability of individual LED control (not just the RGB composition, but each lamp assembly). Please pipe that capability through to the protocol/tools.

samccone commented 6 years ago

I went ahead and made a patch here to support it https://github.com/samccone/weblight/commit/98ec34917785baf40ee255ea5648405e41cb5d03

This change however is somewhat breaking to the API as old 3 byte calls will now set no colors. Thoughts? (if we do not care about backwards compat happy to open a PR with the existing code).

Thanks!

reillyeon commented 6 years ago

Have you tested this with the web app? I don't seen an update to the JavaScript code.

If we have to update the protocol for this we could bump the device version (bcdDevice in the descriptor) so that the app can detect it and send the right command.

samccone commented 6 years ago

Oh I made a new webapp locally that does a few extra things, if you are OK with this patch I can update the existing webapp to use this new protocol.