search

sowderca / connectwise-ruby-sdk

A gem to provide a ruby client to Connectwise's REST API
10 stars 17 forks source link

URI.escape is obsolete warnings on Ruby 2.7 #14

Open jaredmoody opened 3 years ago

jaredmoody commented 3 years ago 
vendor/bundle/ruby/2.7.0/gems/connectwise-ruby-sdk-2.0.2/lib/connectwise-ruby-sdk/api_client.rb:257: warning: URI.escape is obsolete
vendor/bundle/ruby/2.7.0/gems/connectwise-ruby-sdk-2.0.2/lib/connectwise-ruby-sdk/configuration.rb:173: warning: URI.escape is obsolete
sowderca commented 3 years ago

Hey @jaredmoody. I can re-generate the gem which should resolve this issue, however its still going to be created based upon the old 2019 API specs since those are all I have access to anymore.

If you have access to a developer account and can pull the newer specs the gem could support anything that they've released since v2019.4

Old OpenAPI specs were accessible from here for a while:
"https://api-na.myconnectwise.net/$VERSION/services/ApiTools/ApiDocumentation/json/$ENDPOINT.json"

But they seem to have removed them.

Old redoc stuff is still up though (where the 2019.4 specs come from).

jaredmoody commented 1 year ago

So, only 18 months later 😅

Currently tests break on ruby 3.x so looking to regenerate this for ruby 3 compatibility.

Would it be possible to regenerate the gem with this file?

https://gist.github.com/jaredmoody/0438e1f403c6783e6ba1e791ea247dfa

Thanks!

Jared

sowderca commented 1 year ago

Lemme give it a shot.

jaredmoody commented 1 year ago

Just circling back on this, did the file work for generating?