soybase / jekyll-soybase

SoyBase site, forked from jekyll-legumeinfo mid-2022; built with Jekyll and served on GitHub Pages
Apache License 2.0
2 stars 0 forks source link

Merge #160 failed; Can't merge #161 #162

Closed jd-campbell closed 1 month ago

jd-campbell commented 1 month ago

Nathan,

Chen brought to my attention that my [PR #160 (https://github.com/soybase/jekyll-soybase/pull/160). I remember that there are a few check-links that would fail. But some some reason by pa11y also failed.

Also I am noticed that PR #161 has been approved by me, however the Squash and Merge button is grayed out.

nathanweeks commented 1 month ago

Re 160: known issue -- pa11y checks had never passed Re 161: try clicking on the Squash and Merge button. I think the button not being green is a (new?) visual cue that some checks failed, but the PR looks mergeable.