search

soybase / jekyll-soybase

SoyBase site, forked from jekyll-legumeinfo mid-2022; built with Jekyll and served on GitHub Pages
Apache License 2.0
2 stars 0 forks source link

Custom Example Text in Web Components #76

Closed That-Thing closed 10 months ago

That-Thing commented 10 months ago

Custom example text was added in the 1.3.0 web components release, so I need to know what text to put in the web components on the site (gene and trait search).

For gene search, I need the identifier, description, and gene family ID examples. For trait search, I need traits, pub ID, and an example author.

That-Thing commented 10 months ago

Adding the bug label because the components don't have default examples, so they're left blank.

StevenCannon-USDA commented 10 months ago

I'll propose the following:

Gene search:

identifier:  Glyma.16G044100
description:  proteasome subunit alpha
gene family ID: L_6BFHQX

Trait search:

traits:  Seed weight
pub ID:  10.1371/journal.pone.0054985
example author:  Specht

Notes:

maxglycine commented 10 months ago

I could not get your branch to load up, so I can't review what you have done. I need to know how it looks. I open a code space on your branch and it does not load the html.

That-Thing commented 10 months ago

I could not get your branch to load up, so I can't review what you have done. I need to know how it looks. I open a code space on your branch and it does not load the html.

Do you mean the branch in the web components repository or the recent one updating components to version 1.3.0?

If it's the latter, do you get any errors on startup?

maxglycine commented 10 months ago

I went to issue #76 which you asked for review. It was about web components so I tried to bring up your web-components-1.3 branch and it failed. Which branch should I have looked at?

Rex Nelson

@.***

On Jan 3, 2024, at 8:22 PM, Simon @.***> wrote:



I could not get your branch to load up, so I can't review what you have done. I need to know how it looks. I open a code space on your branch and it does not load the html.

Do you mean the web components branch or the recent one updating components to version 1.3.0?

— Reply to this email directly, view it on GitHubhttps://github.com/soybase/jekyll-soybase/issues/76#issuecomment-1876220387, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADLL6226UJ4QO2M2NWYHXUTYMYG4XAVCNFSM6AAAAABBKV7WHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZWGIZDAMZYG4. You are receiving this because you were assigned.Message ID: @.***>

That-Thing commented 10 months ago

I went to issue #76 which you asked for review. It was about web components so I tried to bring up your web-components-1.3 branch and it failed. Which branch should I have looked at? Rex Nelson @. On Jan 3, 2024, at 8:22 PM, Simon @.> wrote:  I could not get your branch to load up, so I can't review what you have done. I need to know how it looks. I open a code space on your branch and it does not load the html. Do you mean the web components branch or the recent one updating components to version 1.3.0? — Reply to this email directly, view it on GitHub<#76 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADLL6226UJ4QO2M2NWYHXUTYMYG4XAVCNFSM6AAAAABBKV7WHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZWGIZDAMZYG4. You are receiving this because you were assigned.Message ID: @.***>

Do you get any errors when trying to start the web-components-1.3 branch? I can't replicate the issue on my computer.

maxglycine commented 10 months ago

I went to webcomponents-1.3. I made a code space on it. I did not see a "Trait-Search". There was only a Gene_search option. This is what it looks like to me. I was looking for something like what Steven sent, and of course, that was not in the Gene_Search had. I see now that what he said was put on the interface in a way that I was not expecting. It looks ok to me. I assume the Trait_Search will have a similar look. Screen Shot 2024-01-04 at 4 30 50 PM

That-Thing commented 10 months ago

Yes, the new change to the web components allows custom examples to be set for each component. The web-components-1.3 branch just updates the component version in _config.yml and adds the examples to the already in-place gene search.

StevenCannon-USDA commented 10 months ago

Handled in #77; closing.