soyersoyer / cameractrls

Camera controls for Linux
Other
550 stars 23 forks source link

refactor: simplify usage of byte strings #24

Closed pohlt closed 1 year ago

soyersoyer commented 1 year ago

Python has a bytes.fromhex, which I think is faster than hexdump2bytes.

I am not convinced yet, that adding runtime overhead for better looking bytes is a good idea.

I like the default python byte description, because it's easier to read. You can see where the byte boundaries are. It's harder to write, but this is the rarest.

pohlt commented 1 year ago

Your call. No hard feelings if you reject it. :-)

On 8 June 2023 19:02:33 CEST, soyer @.***> wrote:

Python has a bytes.fromhex, which I think is faster than hexdump2bytes.

I am not convinced yet, that adding runtime overhead for better looking bytes is a good idea.

I like the default python byte description, because it's easier to read. You can see where the byte boundaries are. It's harder to write, but this is the rarest.

-- Reply to this email directly or view it on GitHub: https://github.com/soyersoyer/cameractrls/pull/24#issuecomment-1583036322 You are receiving this because you authored the thread.

Message ID: @.***>