search

soygabimoreno / Base

Base repo.
Apache License 2.0
14 stars 10 forks source link

[FEATURE][https://github.com/soygabimoreno/Base/issues/13] -- Change … #14

Closed repleyva closed 1 year ago

repleyva commented 1 year ago

…the app name from "Gabi Moreno" to "Los androides".

:tophat: How was this resolved?

I changed the app name to Los androides in the strings files for debug and production.

soyjimmysaenz commented 1 year ago

👋 @repleyva! I guess there are a couple of missing minor changes but don't worry because they are not as important as what you already did:

  1. string resource: playback_notification_channel_name
  2. README.md (three coincidences)

What are your thoughts @soygabimoreno ? does it make sense to include these changes?

I hope this will be helpful.

soygabimoreno commented 1 year ago

wave @repleyva! I guess there are a couple of missing minor changes but don't worry because they are not as important as what you already did:

  1. string resource: playback_notification_channel_name
  2. README.md (three coincidences)

What are your thoughts @soygabimoreno ? does it make sense to include these changes?

I hope this will be helpful.

Good catch, @soyjimmysaenz! Could you include the changes that Jimmy commented in the PR, @repleyva?

Thank you so much for doing it. I love you are collaborating on the project!

repleyva commented 1 year ago

wave @repleyva! I guess there are a couple of missing minor changes but don't worry because they are not as important as what you already did:

  1. string resource: playback_notification_channel_name
  2. README.md (three coincidences)

What are your thoughts @soygabimoreno ? does it make sense to include these changes? I hope this will be helpful.

Good catch, @soyjimmysaenz! Could you include the changes that Jimmy commented in the PR, @repleyva?

Thank you so much for doing it. I love you are collaborating on the project!

Sure!

repleyva commented 1 year ago

👋 @repleyva! I guess there are a couple of missing minor changes but don't worry because they are not as important as what you already did:

  1. string resource: playback_notification_channel_name
  2. README.md (three coincidences)

What are your thoughts @soygabimoreno ? does it make sense to include these changes?

I hope this will be helpful.

Thanks @soyjimmysaenz 🥳