search

soygul / NBug

Automated bug reporting library for .NET
http://soygul.com/nbug
MIT License
191 stars 78 forks source link

Updates Dependencies (Ready to Merge) #83

Closed CDAGaming closed 7 years ago

CDAGaming commented 7 years ago

Sorry in Advance if any Duplicate Commits come in because of merging with this branch 👍

CDAGaming commented 7 years ago

XUnit Deps may have some issues, but ill try to migrate them over within a few days

CDAGaming commented 7 years ago

Forgot to mark as ready

soygul commented 7 years ago

As far as I know, changing TargetFrameworkVersion and ToolsVersion to latest will force people to have latest .net framework and visual studio versions. Don't think that is appropriate.

CDAGaming commented 7 years ago

.Net 4.5.2 was the minimum requirement for some of the Dependency Updates. The toolsversion however, was from an auto upgrade on visual studios end, which I can undo manually to maintain compatibility in that area @soygul

soygul commented 7 years ago

I don't think forcing latest .net version for the entire lib just to update azure stuff is appropriate. This lib works fine with mono too. It won't the case any more if I merge this. Other parts of the PR is good though (editor config, minor changes). You can make smaller PRs for them if you want to.

CDAGaming commented 7 years ago

Ok, I'll do it when i have some time