soyjavi / QuoJS

Micro #JavaScript Library for Mobile Devices
MIT License
2.07k stars 236 forks source link

Library doesn't work on Galaxy Tab #46

Closed majimekun closed 11 years ago

majimekun commented 11 years ago

Hi there,

I've tested QuoJS on several devices but I couldn't get it working on Samsung Galaxy Tab with Android 3.2 (Japanese version, Webkit version unknown)

The test script I used :

    $$('.sidenav').swipeLeft(function() {
      alert("nav");
    });

    $$('.page-content').swipeRight(function() {
      alert("content");
    });

This worked even on my old HTC Wildfire(Android 2.2.1, Webkit 3.1) which I found rather odd.

Thanks in advance for any feedback.

Cheers

soyjavi commented 11 years ago

Samsung Galaxy Tab with Android 3.2 (Japanese version, Webkit version unknown) ... You should send me more information :)

majimekun commented 11 years ago

Hi again :) Well the WebKit version can't be find in the device itself (or I was looking at the wrong place) but I found the device's specs here : https://www.handsetdetection.com/properties/vendormodel/Samsung/Galaxy%20Tab%207.0%20Plus%20SC-02d (webKit version at the bottom of the page) Cheers

soyjavi commented 11 years ago

The problem is that QuoJS doesn't detect that your browser agent is correct.

https://github.com/soyjavi/QuoJS/blob/master/src/quo.environment.coffee

majimekun commented 11 years ago

Sorry, I don't understand the reason why the browser agent can't be detected in this particular case :( Also, why do we have to detect the environment in the first place?

soyjavi commented 11 years ago

because we need to know if we can subscribe to touch events or click events.

El lunes, 4 de febrero de 2013, majimekun escribió:

Sorry, I don't understand the reason why the browser agent can't be detected in this particular case :( Also, why do we have to detect the environment in the first place?

— Reply to this email directly or view it on GitHubhttps://github.com/soyjavi/QuoJS/issues/46#issuecomment-13101777.