soyjavi / QuoJS

Micro #JavaScript Library for Mobile Devices
MIT License
2.07k stars 236 forks source link

Bug fix: Quo element is an empty array. #49

Closed mark-bradshaw closed 11 years ago

mark-bradshaw commented 11 years ago

I'm encountering an odd edge condition when doing jasmine testing on my app that is for some reason causing the "this" object in quo.element.coffee attr function to be an empty array. I haven't quite determined why the object ends in this condition, but in some cases it is happening. In any case, adding this error check let's quo continue to function.

I don't believe that this error check could cause any issue that would break functionality, so I think it's a safe addition.

soyjavi commented 11 years ago

version of quojs?

El jueves, 14 de febrero de 2013, mbradshawabs escribió:

I'm encountering an odd edge condition when doing jasmine testing on my app that is for some reason causing the "this" object in quo.element.coffee attr function to be an empty array. I haven't quite determined why the object ends in this condition, but in some cases it is happening. In any case, adding this error check let's quo continue to function.

I don't believe that this error check could cause any issue that would

break functionality, so I think it's a safe addition.

You can merge this Pull Request by running

git pull https://github.com/americanbible/QuoJS master

Or view, comment on, or merge it at:

https://github.com/soyjavi/QuoJS/pull/49 Commit Summary

  • Adding an error check for an odd element condition that occurs occasionally when doing jasmine testing.

File Changes

  • M src/quo.element.coffeehttps://github.com/soyjavi/QuoJS/pull/49/files#diff-0(2)

Patch Links:

mark-bradshaw commented 11 years ago

QuoJS v2.3.1 - 2/4/2013

soyjavi commented 11 years ago

Thanks!!!

mark-bradshaw commented 11 years ago

Thank you!