soyturk / minify

Automatically exported from code.google.com/p/minify
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Conditional GET Header If-Modified-Since only results in proper 304 response if value is equal to Last-Modified #149

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Make a GET request to Minify with a If-Modified-Since header > Last-Modified

What is the expected output? What do you see instead?

According to the W3C spec:
>If the variant has not been modified since a valid If-Modified-Since date,
the server SHOULD return a 304 (Not Modified) response.
http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.25

The expected response is a 304 status code.

Instead, a 200 OK (along with the requested body) is returned.

Attached is a patch to get the expected behavior

Original issue reported on code.google.com by mwhoo...@gmail.com on 11 Dec 2009 at 1:41

Attachments:

GoogleCodeExporter commented 9 years ago
Excellent patch, thanks.

Original comment by mrclay....@gmail.com on 11 Dec 2009 at 11:32

GoogleCodeExporter commented 9 years ago
In R411 and will be in next release.

Original comment by mrclay....@gmail.com on 9 May 2010 at 4:50