soyturk / minify

Automatically exported from code.google.com/p/minify
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

YUICompressor exceptions #151

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
YUICompressor Exception should be more detailed.
Minify_YUICompressor::_prepare() should be changed to:

    private static function _prepare()
    {
        if (!is_file(self::$jarFile)) {
            throw new Exception('Minify_YUICompressor: $jarFile
('.self::$jarFile.') is not a valid file.');
        }
        if (!is_dir(self::$tempDir)) {
            throw new Exception('Minify_YUICompressor: $tempDir
('.self::$tempDir.') is not a valid direcotry.');
        }
        if (!is_writable(self::$tempDir)) {
            throw new Exception('Minify_YUICompressor: $tempDir
('.self::$tempDir.') is not writable.');
        }
    }

Minify version: 2.1.3
PHP version: 5.3

Original issue reported on code.google.com by Peta...@gmail.com on 22 Dec 2009 at 7:50

GoogleCodeExporter commented 9 years ago
Good idea. Thanks.

Original comment by mrclay....@gmail.com on 22 Dec 2009 at 8:00

GoogleCodeExporter commented 9 years ago
This seems to be in (at least) 2.1.5!

Original comment by elan.ruu...@gmail.com on 29 Mar 2012 at 7:51

GoogleCodeExporter commented 9 years ago
Thanks for catching these.

Original comment by mrclay....@gmail.com on 29 Mar 2012 at 8:13

GoogleCodeExporter commented 9 years ago
i mean "those checks are in 2.1.5 release", so you can close the ticket :)

Original comment by elan.ruu...@gmail.com on 30 Mar 2012 at 10:13

GoogleCodeExporter commented 9 years ago
ok, nvm, it is closed, i mislooked it status "verified" as state

Original comment by elan.ruu...@gmail.com on 30 Mar 2012 at 10:14