search

soyuka / pidusage

Cross-platform process cpu % and memory usage of a PID
MIT License
512 stars 55 forks source link

beforeExit clean interval to free the event loop #78

Closed soyuka closed 6 years ago

soyuka commented 6 years ago

77

codecov-io commented 6 years ago

Codecov Report

Merging #78 into master will increase coverage by 1.09%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   90.74%   91.83%   +1.09%     
==========================================
  Files           9        9              
  Lines         335      343       +8     
==========================================
+ Hits          304      315      +11     
+ Misses         31       28       -3
Impacted Files Coverage Δ
lib/history.js 97.82% <100%> (+2.95%) :arrow_up:
index.js 100% <100%> (ø) :arrow_up:
lib/procfile.js 90.62% <0%> (+3.12%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1740a4f...2779e52. Read the comment docs.

simonepri commented 6 years ago

We should add a test for that thing

soyuka commented 6 years ago

We should add a test for that thing

Yes but it's not that easy. My idea was to set up a script that has exit hooks to gracefully exit. Then launch this script as a child process. It won't show in the coverage though.

LMK if you have something else in mind.

simonepri commented 6 years ago

I think that is the way to go!