search

soywiz-archive / typescript-node-definitions

TypeScript's typings for some popular node.js modules
207 stars 93 forks source link

Updating node.d.ts to Latest in typescript samples #13

Closed sudsy closed 11 years ago

sudsy commented 11 years ago

Updating node definitions to the latest found in develop branch of https://typescript.codeplex.com/SourceControl/BrowseLatest

Main change is that a number of interfaces have been converted to classes so they can be extended - EventEmitter is a good example

soywiz commented 11 years ago

It revert some definition fixes. For example: util.inspect returns a string and with the update it returns void. Maybe it would be great to send those fixes to codeplex so it can be sync safely. Can you check the changes and fix the mistakes and then commit again? Thanks in advance.

sudsy commented 11 years ago

Sorry if I did not make it clear.

I did not make the changes to the file, I just took the latest file in the develop branch of codeplex. If there is a reversion I guess the reason will be in the commit history on codeplex.

I only need this update so I can easily extend EventEmitter so I will keep it in my repo, but you can choose to take the version from the develop branch now, or wait till it is ready for release.

Do I need to branch my repo so that future pull requests don't include the node.d.ts file? Or will my next pull request automatically ignore node.d.ts if I don't make any further changes. Sorry, I am a bit of a noob at github.

Ben

It revert some definition fixes. For example: util.inspect returns a string and with the update it returns void. Maybe it would be great to send those fixes to codeplex so it can be sync safely. Can you check the changes and fix the mistakes and then commit again? Thanks in advance.

— Reply to this email directly or view it on GitHubhttps://github.com/soywiz/typescript-node-definitions/pull/13#issuecomment-15634753 .