soywod / react-pin-field

📟 React component for entering PIN codes.
https://soywod.github.io/react-pin-field/
MIT License
413 stars 24 forks source link

Disable logs via prop #33

Closed amittexel closed 2 years ago

amittexel commented 3 years ago

Im trying to disable the logs spamming the console on development evn, Any props to do so? couldn't find any documentation regarding this issue.

utils.ts:22 [React PIN Field] (notifier) focus-input: idx=0
utils.ts:22 [React PIN Field] (main) event: key-down,idx=0,key=/
utils.ts:22 [React PIN Field] (reducer) handle-key-down: key=/
utils.ts:22 [React PIN Field] (notifier) reject-key: idx=0,key=/
utils.ts:22 [React PIN Field] (main) event: key-up,idx=0
utils.ts:22 [React PIN Field] (reducer) handle-key-up: ignored
utils.ts:22 [React PIN Field] (main) event: key-down,idx=0,key=ע
utils.ts:22 [React PIN Field] (reducer) handle-key-down: key=ע
utils.ts:22 [React PIN Field] (notifier) reject-key: idx=0,key=ע
utils.ts:22 [React PIN Field] (main) event: key-up,idx=0
utils.ts:22 [React PIN Field] (reducer) handle-key-up: ignored
utils.ts:22 [React PIN Field] (main) event: key-down,idx=0,key=2
utils.ts:22 [React PIN Field] (reducer) handle-key-down: key=2
utils.ts:22 [React PIN Field] (notifier) set-input-val: idx=0,val=2
utils.ts:22 [React PIN Field] (notifier) resolve-key: idx=0,key=2
utils.ts:22 [React PIN Field] (notifier) focus-input: idx=1
utils.ts:22 [React PIN Field] (main) event: focus,idx=1
utils.ts:22 [React PIN Field] (notifier) handle-code-change: code={2}
utils.ts:22 [React PIN Field] (notifier) focus-input: idx=1
utils.ts:22 [React PIN Field] (main) event: key-up,idx=1
utils.ts:22 [React PIN Field] (reducer) handle-key-up: ignored
utils.ts:22 [React PIN Field] (main) event: key-down,idx=1,key=ב
utils.ts:22 [React PIN Field] (reducer) handle-key-down: key=ב
utils.ts:22 [React PIN Field] (notifier) reject-key: idx=1,key=ב
utils.ts:22 [React PIN Field] (main) event: key-up,idx=1
utils.ts:22 [React PIN Field] (reducer) handle-key-up: ignored
utils.ts:22 [React PIN Field] (main) event: key-down,idx=1,ignored-key=Alt
utils.ts:22 [React PIN Field] (main) event: key-down,idx=1,ignored-key=Shift
utils.ts:22 [React PIN Field] (main) event: key-up,idx=1
utils.ts:22 [React PIN Field] (reducer) handle-key-up: ignored
utils.ts:22 [React PIN Field] (main) event: key-up,idx=1
utils.ts:22 [React PIN Field] (reducer) handle-key-up: ignored
utils.ts:22 [React PIN Field] (main) event: key-up,idx=1
utils.ts:22 [React PIN Field] (reducer) handle-key-up: ignored
utils.ts:22 [React PIN Field] (main) event: focus,idx=0
2utils.ts:22 [React PIN Field] (reducer) handle-key-up: ignored
utils.ts:22 [React PIN Field] (notifier) focus-input: idx=0
utils.ts:22 [React PIN Field] (main) event: key-down,idx=0,key=q
utils.ts:22 [React PIN Field] (reducer) handle-key-down: key=q
utils.ts:22 [React PIN Field] (notifier) set-input-val: idx=0,val=q
utils.ts:22 [React PIN Field] (notifier) resolve-key: idx=0,key=q
utils.ts:22 [React PIN Field] (notifier) focus-input: idx=1
utils.ts:22 [React PIN Field] (main) event: focus,idx=1
utils.ts:22 [React PIN Field] (notifier) handle-code-change: code={q}
utils.ts:22 [React PIN Field] (notifier) focus-input: idx=1
utils.ts:22 [React PIN Field] (main) event: key-up,idx=1
utils.ts:22 [React PIN Field] (reducer) handle-key-up: ignored
utils.ts:22 [React PIN Field] (main) event: key-down,idx=1,key=g
utils.ts:22 [React PIN Field] (reducer) handle-key-down: key=g
utils.ts:22 [React PIN Field] (notifier) set-input-val: idx=1,val=g
utils.ts:22 [React PIN Field] (notifier) resolve-key: idx=1,key=g
utils.ts:22 [React PIN Field] (notifier) focus-input: idx=2
utils.ts:22 [React PIN Field] (main) event: focus,idx=2
utils.ts:22 [React PIN Field] (notifier) handle-code-change: code={qg}
utils.ts:22 [React PIN Field] (notifier) focus-input: idx=2
utils.ts:22 [React PIN Field] (main) event: key-up,idx=2
utils.ts:22 [React PIN Field] (reducer) handle-key-up: ignored
utils.ts:22 [React PIN Field] (main) event: key-down,idx=2,key=2
soywod commented 3 years ago

Logs are visible when the verbose log level is activated in the console:

screenshot

Remove it and you should not see them anymore!

amittexel commented 3 years ago

They are activated by default for me, on both computers. weird. hopefully not for other users. Thanks! Anyway I would suggest a prop to completely disable them. Great library my friend!

soywod commented 3 years ago

This is how logs work: they always write, but they can be filtered out by users! I am not so fan about adding a prop, it is not the right place IMO. I will reconsider if other people are also bothered by it. Thanks for your feedback!

goonerDp commented 2 years ago

@soywod Could you add the option for disabling debug mode? These logs get into Sentry logs.

soywod commented 2 years ago

Alright, I will add a prop to activate logs!

soywod commented 2 years ago

Prop debug added in v2.0.0-beta.3 (default at false).