search

soywod / react-pin-field

📟 React component for entering PIN codes.
https://soywod.github.io/react-pin-field/
MIT License
412 stars 24 forks source link

Handle dir prop #71

Closed tusmenko closed 1 year ago

tusmenko commented 1 year ago

Now we are handling the direction only from the HTML attribute, while we would like to handle dir component property as well

soywod commented 1 year ago

A test fails but seems unrelated to your work. Does it fail locally also? I check on the develop branch, they all pass :thinking:

tusmenko commented 1 year ago

A test fails but seems unrelated to your work. Does it fail locally also? I check on the develop branch, they all pass 🤔

Nope, locally all good, even tweaking the index.html with dir="rtl" and\or enforcing dir in props. I've considered leftArrow change conditionally to rightArrow based on dir in e2e tests, but seems the browser handles it correctly out of the box.

soywod commented 1 year ago

I will upgrade packages and improve ci tests to see, I let you know when you can rebase locally!

soywod commented 1 year ago

Seems that adding some delay between keystrokes helped. Thank you for your PR, I will publish the v3.1.1 very soon.

tusmenko commented 1 year ago

Thank you, looking forward!