search

sozialhelden / wheelmap-classic

:wheelchair: Legacy "classic" wheelmap.org (deprecated)
http://www.wheelmap.org
GNU Affero General Public License v3.0
46 stars 16 forks source link

Wheelmap missing nodes present in OSM #600

Open ldodds opened 7 years ago

ldodds commented 7 years ago

I recently updated all of the shops on a nearby street on OSM. You can see the latest information here:

http://www.openstreetmap.org/#map=19/51.37687/-2.37849

However the buildings don't have markers on Wheelmap, as seen here:

https://wheelmap.org/map#/?lat=51.37684685328965&lon=-2.378467619419098&zoom=19

I've checked and I think the majority of the missing shops are listed in the node types (https://wheelmap.org/node_types), e.g. there are two hairdressers on the street both marked with shop=hairdresser

E.g. http://www.openstreetmap.org/way/485163935 and http://www.openstreetmap.org/way/485163925

Why would these not be appearing?

Update: I've noticed that the building outlines I've added are present on wheelmap, so some synchronisation is happening, its just not adding markers.

btw, I'm happy to help debug these types of issues, but am not clear which bit of the code I should be looking at. We're running a public mapping event here in Bath so we're keen to offer support

1000miles commented 7 years ago

@ldodds Thanks for reporting this and your offer to help debugging. 👍 We will have a look into this and get back to you asap.

Hoverbear commented 7 years ago

This is likely related to #521.

Hoverbear commented 7 years ago

@ldodds We suspect there might be an issue with the syncing process itself at this point in time, related to some changes in the data OSM sends us and how we process it (with osm2psql). We are investigating.

ldodds commented 7 years ago

Thanks for the update.

ldodds commented 7 years ago

Hello, any update on this issue? We're continuing to update OSM ahead of our mapping event on the 13th. It appears some updates do seem to come through OK (e.g. new points) but others, such as the ones I highlighted above, are still not present.

Am just wondering if there's a short term work around, e.g. adding new items as points rather than polygons?

1000miles commented 7 years ago

@ldodds Thanks for asking.

This is a https://github.com/sozialhelden/wheelmap/issues/521#issuecomment-297948245 from Andrew (@hoverbear) on another Github issue that is related to this issue (nodes disappear):

After a discussion with @Xylakant today we don't really have a good way to test updating this tool.

This is partially due to the fact that none of the other instances of wheelmap we are familiar with are having the same problem.

Updating on production is very risky (since the current version is so old), so it's likely a good idea to avoid trying to do that.

At the moment we unfortunately can not confirm any solution without the possibility of a fully testable environment. We are still investigating this issue and will discuss this internally as soon as @hoverbear is back in the office on monday. Sorry to not have a proper solution at the moment and thank you for your patience.

ldodds commented 7 years ago

I'm not sure if this is part of the same issue, but noting here for now.

A user doing mapping using the app added a comment to a coffee shop. While the comments were saved to OSM, they are not appearing in the mobile or web versions of Wheelmap.

OSM: http://www.openstreetmap.org/way/452678133 Wheelmap: https://wheelmap.org/en/nodes/-452678133

Let me know if I should file this as a separate report. Am a bit concerned that notes will get overwritten or lost if they're not displaying

ghost commented 7 years ago

@ldodds Thank you for letting us know about the notes not being display. I've created a seperate ticket (view here #606 ) and we're investigating this issue.

Unfortunately, concerning the nodes not appearing on wheelmap, I can only offer you the information we already discussed above: There seems to be a bug preventing a small, yet random, number of nodes from showing up on wheelmap. However, all information from your mapping event is saved (including comments to places) and we're working on getting them to display.

If you have any further questions, don't hesitate to let us know.

holgerd commented 7 years ago

For documentation:

Here is another example of a place in OSM which does not show up in Wheelmap:

https://www.openstreetmap.org/way/164651993

https://wheelmap.org/en/map#/?categories=accommodation.money_post.education.food.government.health.leisure.misc.shopping.sport.tourism&lat=51.37699167329935&lon=-2.3786433041095734&zoom=19

pyrog commented 6 years ago

Another example is "le fournil du lizon". It is not yet visible on MapBox/Wheelmap but is there on OSM

The node "coccinelle saint-lupicin" was updated in OSM but not yet in Wheelmap.

HAZET commented 6 years ago

There still seem to be syncing-issues. Two examples: A node: https://www.openstreetmap.org/node/5325730972 A polygon: https://www.openstreetmap.org/way/418400385#map=18/53.60040/9.97876 Neither a OSM-pro nor a good coder, but quit good ad analyzing and debugging, I would help fixing if I knew where to start.