sozialhelden / wheelmap-classic

:wheelchair: Legacy "classic" wheelmap.org (deprecated)
http://www.wheelmap.org
GNU Affero General Public License v3.0
46 stars 16 forks source link

[DONT MERGE YET] fix: misspelling typo #608

Closed emig closed 2 years ago

emig commented 7 years ago

note:

@Hoverbear couldn't get the link on local machine, is it because locally we are missing the region, and therefore we don't have that feature activated? Therefore I couldn't test this fix works ...

screen shot 2017-05-12 at 10 33 43

closes #598

Hoverbear commented 7 years ago

You can test this by either removing the exclude filter, or increasing the accuracy to like 100000 in app/views/nodes/_node_nearby.html.haml

emig commented 7 years ago

Hum, didn't work with the suggested accuracy changes, seems the node in question doesn't have a region:

https://github.com/sozialhelden/wheelmap/blob/598_mispelling/app/views/nodes/_node_similar.html.haml#L13

Hoverbear commented 7 years ago

Try this:

         limit: 10,
-        excludeSourceIds: ['LiBTS67TjmBcXdEmX'], // excludes Wheelmap's own PoIs from results
+        //excludeSourceIds: ['LiBTS67TjmBcXdEmX'], // excludes Wheelmap's own PoIs from results
       };
emig commented 7 years ago

@Hoverbear none of the pois on the local db has region set, so the line I mentioned before won't be active for any poi. https://github.com/sozialhelden/wheelmap/blob/598_mispelling/app/views/nodes/_node_similar.html.haml#L13

Hoverbear commented 7 years ago

@emig I get results doing this.

emig commented 7 years ago

wasn't ware of the import region rake taks, thanks!

emig commented 7 years ago

@Hoverbear on a fresh install of the project via vagrant the imported data doesn't contain regions. You can test this then, if you have them.

Hoverbear commented 7 years ago

foo

emig commented 7 years ago

We are looking for a link like All places of type ... in Berlin, do you have that? It depends on the POI having a region

Hoverbear commented 7 years ago

Ah, my mistake. I don't see that.