Upgrade accessibility.cloud widget to v3.2.1 (Part II)

sozialhelden / wheelmap-classic

:wheelchair: Legacy "classic" wheelmap.org (deprecated)

http://www.wheelmap.org

GNU Affero General Public License v3.0

46 stars 16 forks source link

Upgrade accessibility.cloud widget to v3.2.1 (Part II) #620

Closed opyh closed 7 years ago

opyh commented 7 years ago

Fix the issue we had with the JS minifier when deploying the changes in #604
Add 2 missing translation strings
CSS fix for bottom padding below places nearby results

holgerd commented 7 years ago

What is the next step here? @Hoverbear to review this, correct?

Hoverbear commented 7 years ago

@holgerd Yes :)

1000miles commented 7 years ago

@holgerd cc @opyh

Deployed to staging with release 20170530082716 today.

Example node: https://staging.wheelmap.org/nodes/2708872307

Screens:

Firefox (disabled privacy blocker)

00000328

Chrome (disabled privacy blocker)

00000329

1000miles commented 7 years ago

@opyh cc @holgerd @anngreenberg

Adding the screenshot with enabled privacy blocker

screen shot 2017-05-31 at 15 09 19

Hoverbear commented 7 years ago

@1000miles It's because you have accessibility.cloud blocked in Privacy Badger. In this case privacy badger is doing its job. :) Just flick it over to yellow and it should start working.

opyh commented 7 years ago

Hmm. I think privacy badger has a point there. It would be better to not rely on jsdelivr, but to serve the script through our own CDN. I'm about to set up fastly for accessibility.cloud soon anyway, then we can move it there. I'd keep the issue open until then. What do you think?

1000miles commented 7 years ago

@Hoverbear Thanks but the concern was rather how do I know of the AC widget existence if I permanently have my privacy blocker enabled and there is no hint about it to turn it on in order to see it. :)

@opyh Sounds good to less rely on external CDNs. Let's continue the discussion directly on the Github issue #623 to keep overview?