search

sozialhelden / wheelmap-classic

:wheelchair: Legacy "classic" wheelmap.org (deprecated)
http://www.wheelmap.org
GNU Affero General Public License v3.0
46 stars 16 forks source link

Photos do not reflect original EXIF orientation #636

Closed 1000miles closed 7 years ago

1000miles commented 7 years ago

This is a follow-up of the comment mentioned in ticket https://github.com/sozialhelden/wheelmap/issues/167#issuecomment-311608771.

At the moment when we upload images manually through the browser the images are shown as expected. But when we import the images through the bulk import some images seem to not have the correct position. Since the function fix_exif_orientation (https://github.com/sozialhelden/wheelmap/blob/master/config/initializers/carrierwave.rb#L4-L10) exists we expected all uploaded images (manually and through bulk import) to display the images as the original EXIF orientation. But this is unfortunately not the case.

Needs further investigation why some images do not display correctly even if the original exif orientation shows a correct position.

Example node: https://wheelmap.org/nodes/4116869491

Screenshot Example:

00000375

1000miles commented 7 years ago

Update, 2017-07-2017

Looking at the download links of streetspotr our hunch is now that the problem with the incorrect image positions happen before or on upload on the streetspotr server side, e.g. https://download.streetspotr.com/d2c6686b0931b938026e94254667a4fd1eef7118/c8a0e7b79ced3df0328ba306232bc05e7a5c6c99.

If our assumption is correct, we can not do anything here because we fetch these images as they are uploaded by streetspotr. @Svenyo Could you please talk to streetspotr and let streetspotr confirm our hunch? Merci.

We will put this ticket on hold meanwhile.

00000376

cc @holgerd @anngreenberg

Svenyo commented 7 years ago

@1000miles I forwarded this to Streetspotr. Will let you know when there's an answer.

1000miles commented 7 years ago

@Svenyo Before we start another streetspotr import with #651 , do you know if Streetspotr has fixed this issue (images upside down) meanwhile?

cc @anngreenberg

Svenyo commented 7 years ago

@1000miles They confirmed that they had forwarded this bug to the IT team and fixed it, yes. Let's see if it works! :-)

1000miles commented 7 years ago

@Svenyo cc @holgerd @anngreenberg

We checked the newest streetspotr Sept 2017 batch from ticket #651 . Unfortunately the image distortion is not fixed yet.

You can view examples here:

DE_2016.csv:

Download URLs:

Production POI:

1000miles commented 7 years ago

A few more examples where the exif orientation issue still exist.

Photos uploaded via streetspotr on 2017-09-11:

Svenyo commented 7 years ago

@1000miles: Yes, the problem was solved on August 11 from the part of the Streetspotr IT, so a lot of pics taken before that date are still displayed in a rotated view. After August 11 all pics are displayed correctly. So, at least for the next campaign, this problem will be solved.

ghost commented 7 years ago

As @Svenyo mentioned, for future contributions the problem will be solved. Therefore closing.