search

sozorogami / gover

Gather all your *.coverprofile files to send to coveralls.io!
Apache License 2.0
56 stars 9 forks source link

Concatenates gover.coverprofile on itself #4

Closed porridge closed 6 years ago

porridge commented 7 years ago

I think this picture speaks for itself:

porridge@beczulka:~/Desktop/coding/go/src/k8s.io/ingress$ ls -l gover.coverprofile;gover
ls: cannot access gover.coverprofile: No such file or directory
porridge@beczulka:~/Desktop/coding/go/src/k8s.io/ingress$ ls -l gover.coverprofile;gover
-rw-r----- 1 porridge eng 146137 lut 24 14:58 gover.coverprofile
porridge@beczulka:~/Desktop/coding/go/src/k8s.io/ingress$ ls -l gover.coverprofile;gover
-rw-r----- 1 porridge eng 292264 lut 24 14:58 gover.coverprofile
porridge@beczulka:~/Desktop/coding/go/src/k8s.io/ingress$ ls -l gover.coverprofile;gover
-rw-r----- 1 porridge eng 438391 lut 24 14:58 gover.coverprofile
porridge@beczulka:~/Desktop/coding/go/src/k8s.io/ingress$

This means gover.coverprofile needs to be explicitly cleaned up before each execution of gover. Otherwise it causes data corruption and can lead to goveralls crashing (https://github.com/mattn/goveralls/issues/86).

This happened for us in https://github.com/kubernetes/ingress/issues/338.

Is this by design, or a bug?