search

sozu-proxy / circular

stream abstraction designed for use with nom
MIT License
11 stars 7 forks source link

Add getter for position #1

Closed Freyskeyd closed 7 years ago

Freyskeyd commented 7 years ago

Add a getter to the position.

Signed-off-by: Freyskeyd simon.paitrault@gmail.com

Geal commented 7 years ago

Why is it needed?

Freyskeyd commented 7 years ago

The getter is a useful information to display (I used it in trace!) For the setter I don't know, maybe it's completely useless ?

Geal commented 7 years ago

The getter can be useful, but the setter would break the behaviour of the buffer

Le 5 mai 2017 09:10, "Simon Paitrault" notifications@github.com a écrit :

The getter is a useful information to display (I used it in trace!) For the setter I don't know, maybe it's completely useless ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sozu-proxy/circular/pull/1#issuecomment-299397445, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHSABnlDcDlBWDGLS2PEx_R-xPlmvzqks5r2stIgaJpZM4NRK4s .

Freyskeyd commented 7 years ago

That's right, I will remove it.

Freyskeyd commented 7 years ago

I've a question about how this repository is named. Circular but the main struct if Buffer. Would keep that way?

Geal commented 7 years ago

probably, it's just a crate name