search

sozu-proxy / sozu

Sōzu HTTP reverse proxy, configurable at runtime, fast and safe, built in Rust. It is awesome!
https://www.sozu.io/
GNU Affero General Public License v3.0
3.01k stars 187 forks source link

should the command buffer size really be capped? #1050

Open Keksoj opened 9 months ago

Keksoj commented 9 months ago

Anytime the max_command_buffer_size is too small and we get this error:

channel buffer is full ({0} bytes), cannot grow more

we end up upping the value in the config and we go on.

Is an upper limit really useful? What's the worst that could happen here? Our channels will soon transmit binary serializations of protobuf messages, this leaves little room for errors.