Protobuf access logs - Githubissues

sozu-proxy / sozu

Sōzu HTTP reverse proxy, configurable at runtime, fast and safe, built in Rust. It is awesome!

https://www.sozu.io/

GNU Affero General Public License v3.0

3.12k stars 193 forks source link

Protobuf access logs #1069

Closed Keksoj closed 8 months ago

Keksoj commented 9 months ago

Adding the option to produce access logs in a binary format will be highly beneficial for performance and parseability.

This PR creates a binary type BinaryAccessLog using protobuf, that are emitted with a delimiter for easier parsing.

Keksoj commented 9 months ago

@FlorentinDUBOIS should we rather have "binary" or "protobuf" as a configurable option, and for types ? We may introduce other binary types in the future, so we can disambiguate right now.

Wonshtrum commented 9 months ago

I have some todos left:

[x] document, change, or delete the use of unsafe static mut (for log call site caches)
[x] make sure the new ASCII access log format is "good" and consistent with our internal parsers
[x] make sure the ownership duplication is safe and necessary

Keksoj commented 8 months ago

This is ready for review and mergeable in our opinion.