search

sozu-proxy / sozu

Sōzu HTTP reverse proxy, configurable at runtime, fast and safe, built in Rust. It is awesome!
https://www.sozu.io/
GNU Affero General Public License v3.0
3.12k stars 193 forks source link

build: fix osx build #1136

Open anonkey opened 2 months ago

anonkey commented 2 months ago

Hi, i hade some trouble to build on mac os aarch64, needed some small fixes. Moreover --no-default-feature wasn't working for full workspace build i replaced it for cfg() directive in cargo.toml to rely on sse4.2 feature presence

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

Wonshtrum commented 1 month ago

Hi! Sorry for the late answer. Thanks for your interest in Sozu! The PR seems great, we never took the time to integrate SIMD into the build properly. But I'm confused, your configuration seems backward:

[target.'cfg(not(target_feature = "sse4.2"))'.dependencies]
kawa = { version = "^0.6.6" } # kawa default is to use SSE

[target.'cfg(target_feature = "sse4.2")'.dependencies]
kawa = { version = "^0.6.6", default-features = false } # removing default, kawa will not use SSE

Did this configuration really work on your mac os aarch64?