sozykinsa / GUI4dft

GUI4dft - first free SIESTA oriented GUI
MIT License
21 stars 6 forks source link

25 remove all critical points functionality #26

Closed sozykinsa closed 1 year ago

sozykinsa commented 1 year ago

Done

codecov[bot] commented 1 year ago

Codecov Report

Base: 76.98% // Head: 85.00% // Increases project coverage by +8.02% :tada:

Coverage data is based on head (a23dfc6) compared to base (b23663b). Patch coverage: 73.44% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #26 +/- ## ========================================== + Coverage 76.98% 85.00% +8.02% ========================================== Files 28 35 +7 Lines 6582 11223 +4641 ========================================== + Hits 5067 9540 +4473 - Misses 1515 1683 +168 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `85.00% <73.44%> (+8.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Sozykin#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/sozykinsa/GUI4dft/pull/26?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Sozykin) | Coverage Δ | | |---|---|---| | [src/src\_gui4dft/models/volumericdatablock.py](https://codecov.io/gh/sozykinsa/GUI4dft/pull/26/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Sozykin#diff-c3JjL3NyY19ndWk0ZGZ0L21vZGVscy92b2x1bWVyaWNkYXRhYmxvY2sucHk=) | `100.00% <ø> (ø)` | | | [src/src\_gui4dft/qtbased/pyqtgraphwidget.py](https://codecov.io/gh/sozykinsa/GUI4dft/pull/26/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Sozykin#diff-c3JjL3NyY19ndWk0ZGZ0L3F0YmFzZWQvcHlxdGdyYXBod2lkZ2V0LnB5) | `100.00% <ø> (ø)` | | | [src/src\_gui4dft/qtbased/pyqtgraphwidgetimage.py](https://codecov.io/gh/sozykinsa/GUI4dft/pull/26/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Sozykin#diff-c3JjL3NyY19ndWk0ZGZ0L3F0YmFzZWQvcHlxdGdyYXBod2lkZ2V0aW1hZ2UucHk=) | `100.00% <ø> (ø)` | | | [src/src\_gui4dft/ui/about.py](https://codecov.io/gh/sozykinsa/GUI4dft/pull/26/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Sozykin#diff-c3JjL3NyY19ndWk0ZGZ0L3VpL2Fib3V0LnB5) | `23.07% <ø> (ø)` | | | [src/src\_gui4dft/ui/form.py](https://codecov.io/gh/sozykinsa/GUI4dft/pull/26/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Sozykin#diff-c3JjL3NyY19ndWk0ZGZ0L3VpL2Zvcm0ucHk=) | `100.00% <ø> (ø)` | | | [src/src\_gui4dft/models/volumericdata.py](https://codecov.io/gh/sozykinsa/GUI4dft/pull/26/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Sozykin#diff-c3JjL3NyY19ndWk0ZGZ0L21vZGVscy92b2x1bWVyaWNkYXRhLnB5) | `58.08% <5.08%> (ø)` | | | [src/core\_gui\_atomistic/gui4dft\_project\_file.py](https://codecov.io/gh/sozykinsa/GUI4dft/pull/26/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Sozykin#diff-c3JjL2NvcmVfZ3VpX2F0b21pc3RpYy9ndWk0ZGZ0X3Byb2plY3RfZmlsZS5weQ==) | `17.77% <17.77%> (ø)` | | | [src/src\_gui4dft/program/ase.py](https://codecov.io/gh/sozykinsa/GUI4dft/pull/26/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Sozykin#diff-c3JjL3NyY19ndWk0ZGZ0L3Byb2dyYW0vYXNlLnB5) | `4.72% <38.46%> (ø)` | | | [src/core\_gui\_atomistic/guiopenglbase.py](https://codecov.io/gh/sozykinsa/GUI4dft/pull/26/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Sozykin#diff-c3JjL2NvcmVfZ3VpX2F0b21pc3RpYy9ndWlvcGVuZ2xiYXNlLnB5) | `47.68% <42.55%> (ø)` | | | [src/src\_gui4dft/qtbased/guiopengl.py](https://codecov.io/gh/sozykinsa/GUI4dft/pull/26/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Sozykin#diff-c3JjL3NyY19ndWk0ZGZ0L3F0YmFzZWQvZ3Vpb3BlbmdsLnB5) | `52.00% <52.00%> (ø)` | | | ... and [33 more](https://codecov.io/gh/sozykinsa/GUI4dft/pull/26/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Sozykin) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Sozykin). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Sozykin)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

sozykinsa commented 1 year ago

all critical points functionality was removed