Negative rep killing pmc's as scav

sp-tarkov / server

University of Illinois/NCSA Open Source License

0 stars 2 forks source link

Negative rep killing pmc's as scav #284

Open refringe opened 1 hour ago

refringe commented 1 hour ago

General information

Project issue is for: Server

Expected result: Gain correct amount of karma for killing PMC's as player scav

Actual result: Killing PMC's is counted as killing scav's, giving negative rep

The info screen at the end of raid shows PMC kills but the standing says scavs

How to reproduce

Scav into factory
Kill multiple PMC's
Exit or die
See standing changes

Screenshots

Attachments

image.png (834 KiB)
image.png (1655 KiB)
image.png (1626 KiB)
server-2024-05-23.log (818 KiB)
LogOutput.log (21 KiB)
2024.05.24_0-29-36_0.14.8.0.29997_backend.log (46 KiB)

Originally written by Cardsmen

refringe commented 1 hour ago

Can you confirm if it actually lowered the rep or not? I think there’s a chance this could be a visual or calculation bug.

Originally written by PhantomInTime

refringe commented 1 hour ago

This is rep before a scav run this is rep after

Now, I didnt kill anything and got lasered pretty quick and only got a few hits. but I did hear a scav die. Im wondering if when AI PMC's kill scavs its somehow counting it towards the player but only affecting the rep

Attachments

image.png (28 KiB)
image.png (28 KiB)

Originally written by Cardsmen

refringe commented 1 hour ago

fixed with https://github.com/sp-tarkov/modules/commit/d6dd573e88f9fa35526838f57c393b2ba82b91b5

Looks like Gclass ref didnt get updated correctly. I also added some Safeguards so it will only work when its your player

Originally written by Kaeno

refringe commented 1 hour ago

can this be confirmed if fixed? @Cardsmen

Originally written by CWX

refringe commented 1 hour ago

Last I looked the ai pmcs killing scavs was fixed. But I thought I noticed that xp for killing ai pmc's as a scav may have been broken. I've been busy so idk if it's been addressed.

If someone wants to look into it I'd try testing killing pmc's that have killed scavs for +.02 Kill a traitor scav as a scav for +.03

If that needs to be it's own issue then close this and I'll get to it when I get to it.

Originally written by Cardsmen