sp-tarkov / server

University of Illinois/NCSA Open Source License
0 stars 2 forks source link

Fence Rep Changing Unexpectedly #364

Closed refringe closed 2 hours ago

refringe commented 2 hours ago

General information

Project issue is for: SPT-NIGHTLY-3.8.0-29197-d3fdb08-20240323

Expected result: Fence rep should remain the same

Actual result: Fence rep reducing on scav death

I have noticed that if I take a vehicle extract as a pmc and get the fence rep gain, if I then go into the following raid as a scav and die it takes away the fence rep gained from the previous vehicle extract. Just recreated it on a new profile. Did EOD edition, started with .20 scav rep. Ran Ground Zero and took vehicle extract. Fence rep went up to .40. Entered a factroy raid as a scav and just ran around until I found a PMC to let kill me. After raid fence rep was back at .20. Fresh install, with newest dev-core zip as well.

How to reproduce

  1. Enter a raid as a PMC and take a vehicle extract
  2. Note Fence rep after raid
  3. Enter a raid as a Scav and die
  4. Note Fence rep after raid

Attachments


Originally written by Scavnagoodtime

refringe commented 2 hours ago

it seems like we arent copying over the new Fence reputation data to the scav after running handleCarExtract. so the Scav data is now stale for the next time the player runs a scav. pmcdata: image

scavdata: image


Attachments


Originally written by Kaeno

refringe commented 2 hours ago

This is happening because we are now trusting the client for rep changes when we are a scav. We use to only look at the PMCs fence reputation and calculate based on that.

https://dev.sp-tarkov.com/SPT-AKI/Server/commit/d5517d7fdf2cd57efd69a6e14e511d026937c0c8 is the change that made the server trust the client.


Originally written by Kaeno

refringe commented 2 hours ago

Hopefully fixed with: https://dev.sp-tarkov.com/SPT-AKI/Server/commit/eca6f4bd75eed75890e8a6e52acf4d0d69d758c9


Originally written by chomp

refringe commented 2 hours ago

Re-tested on most recent zip (9fca68) and rep is now functioning as intended. Problem seems to be resolved.


Originally written by Scavnagoodtime